Can anyone tell me if this setup is correct for adding neon lights to either work with the dome lighting or just constant on/off while driving.

When the doors open it will activate the relays connecting 30 and 87 on the relays so that it will be connected to the dome harness (positive and negative sides) which should also allow it to fade since it connects the +/- of the neons to the dome harness.

When the doors close the relay is not active and 30 and 87A on the relays so that it will be is connected to the ground (car metal) and +12V from the fuse panel via a switch which allows it to turn on and off as you wish as long as the key is in.

 

it looks good to me unless someone else sees something wrong. isn't using the dome power and ground to activate the relays as well as to power the neons a bit much in terrms of current draw? if you want this to work with the key, you wire a switched 12v source and not constant.